<html>
<head><meta charset="utf-8"><title>1.52 release · t-release · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/index.html">t-release</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html">1.52 release</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="236585202"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/236585202" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#236585202">(Apr 28 2021 at 21:38)</a>:</h4>
<p>I’m not sure if I’m putting this in the right thread, but I want to make sure it doesn’t get overlooked. I just posted PR <a href="https://github.com/rust-lang/rust/issues/84672">#84672</a> that does a long discussed revert of PR <a href="https://github.com/rust-lang/rust/issues/76570">#76570</a> on beta branch.</p>



<a name="236585266"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/236585266" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#236585266">(Apr 28 2021 at 21:38)</a>:</h4>
<p>oh never mind, <span class="user-mention" data-user-id="116122">@simulacrum</span> just took care of it. <span aria-label="laughing" class="emoji emoji-1f606" role="img" title="laughing">:laughing:</span></p>



<a name="236585337"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/236585337" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#236585337">(Apr 28 2021 at 21:39)</a>:</h4>
<p>well, it'll need to get r+'d but yeah looks reasonable</p>



<a name="237255042"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237255042" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237255042">(May 04 2021 at 01:21)</a>:</h4>
<p>Kicked off the dev-static promote-release job</p>



<a name="237255113"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237255113" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237255113">(May 04 2021 at 01:22)</a>:</h4>
<p>Probably won't be around to publish the inside rust post and internals post asking for feedback on it, fyi <span class="user-mention" data-user-id="121055">@Pietro Albini</span> - probably good to do first thing tomorrow</p>



<a name="237287889"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237287889" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237287889">(May 04 2021 at 08:38)</a>:</h4>
<p>opened a PR for the post</p>



<a name="237287894"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237287894" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237287894">(May 04 2021 at 08:38)</a>:</h4>
<p><a href="https://github.com/rust-lang/blog.rust-lang.org/pull/831">https://github.com/rust-lang/blog.rust-lang.org/pull/831</a></p>



<a name="237303101"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237303101" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237303101">(May 04 2021 at 10:50)</a>:</h4>
<p><span class="user-mention" data-user-id="121055">@Pietro Albini</span> merged</p>



<a name="237303113"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237303113" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237303113">(May 04 2021 at 10:50)</a>:</h4>
<p><span aria-label="thumbs up" class="emoji emoji-1f44d" role="img" title="thumbs up">:thumbs_up:</span></p>



<a name="237303114"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237303114" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237303114">(May 04 2021 at 10:50)</a>:</h4>
<p>Did you have internals ready to go?</p>



<a name="237303129"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237303129" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237303129">(May 04 2021 at 10:51)</a>:</h4>
<p>yep let me post it</p>



<a name="237303276"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237303276" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237303276">(May 04 2021 at 10:52)</a>:</h4>
<p>Thanks!</p>



<a name="237303342"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237303342" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237303342">(May 04 2021 at 10:53)</a>:</h4>
<p><a href="https://internals.rust-lang.org/t/1-52-0-prerelease-testing/14628">https://internals.rust-lang.org/t/1-52-0-prerelease-testing/14628</a></p>



<a name="237303734"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237303734" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237303734">(May 04 2021 at 10:56)</a>:</h4>
<p>It would likely be a good idea to confirm that the last minute patches actually fixed the bugs they claim to</p>



<a name="237303788"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237303788" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237303788">(May 04 2021 at 10:57)</a>:</h4>
<p>I can try and do that sometime today, though I'll be pretty busy, not sure I'll have time</p>



<a name="237331902"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237331902" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237331902">(May 04 2021 at 14:16)</a>:</h4>
<p>force-pushed beta</p>



<a name="237333427"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237333427" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237333427">(May 04 2021 at 14:26)</a>:</h4>
<p>created a draft PR to help me be organized</p>



<a name="237333438"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237333438" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237333438">(May 04 2021 at 14:26)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/pull/84909">https://github.com/rust-lang/rust/pull/84909</a></p>



<a name="237336317"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237336317" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237336317">(May 04 2021 at 14:43)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> we landed <a href="https://github.com/rust-lang/rust/pull/84759">https://github.com/rust-lang/rust/pull/84759</a> in 1.52, should I also backport it to 1.53?</p>



<a name="237336324"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237336324" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237336324">(May 04 2021 at 14:43)</a>:</h4>
<p><span class="user-mention" data-user-id="310399">@Mara</span> ^</p>



<a name="237336346"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237336346" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237336346">(May 04 2021 at 14:43)</a>:</h4>
<p>yes</p>



<a name="237336372"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237336372" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237336372">(May 04 2021 at 14:43)</a>:</h4>
<p>ok will do</p>



<a name="237337260"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237337260" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Mara <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237337260">(May 04 2021 at 14:49)</a>:</h4>
<p>thanks :)  I'll make sure to do something about this before 1.54 splits off ^^'</p>



<a name="237339385"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237339385" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237339385">(May 04 2021 at 14:59)</a>:</h4>
<p>are you aware <span class="user-mention silent" data-user-id="116122">simulacrum</span> if there are fixes planned for the diagnostics being different in beta and nightly?</p>



<a name="237339411"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237339411" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237339411">(May 04 2021 at 14:59)</a>:</h4>
<p>I remember it's not the first time I had to cherry-pick the same commit</p>



<a name="237339436"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237339436" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237339436">(May 04 2021 at 14:59)</a>:</h4>
<p>no, I've not had time to sit down and figure out what's up with it</p>



<a name="237339480"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237339480" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237339480">(May 04 2021 at 15:00)</a>:</h4>
<p>I don't think anyone else is planning to do anything either</p>



<a name="237339556"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237339556" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237339556">(May 04 2021 at 15:00)</a>:</h4>
<p>we absolutely should though :/</p>



<a name="237339615"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237339615" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237339615">(May 04 2021 at 15:00)</a>:</h4>
<p>I think it's been 3-4 cycles now</p>



<a name="237339638"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237339638" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237339638">(May 04 2021 at 15:00)</a>:</h4>
<p>yeah</p>



<a name="237344546"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237344546" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237344546">(May 04 2021 at 15:17)</a>:</h4>
<p>ok backported everything that was relevant from the 1.52.0 stable PR</p>



<a name="237344588"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237344588" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237344588">(May 04 2021 at 15:17)</a>:</h4>
<p>now going through the regression- labels again to make sure I'm not missing anything, relabeling everything correctly in the meantime</p>



<a name="237344595"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237344595" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237344595">(May 04 2021 at 15:17)</a>:</h4>
<p>I'll then deal with rls/rustfmt</p>



<a name="237344608"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237344608" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237344608">(May 04 2021 at 15:17)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> ^</p>



<a name="237344628"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237344628" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237344628">(May 04 2021 at 15:17)</a>:</h4>
<p>sounds good</p>



<a name="237348486"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237348486" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237348486">(May 04 2021 at 15:41)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> uh wait, <a href="https://github.com/rust-lang/rust/issues/83087">https://github.com/rust-lang/rust/issues/83087</a> is a 1.52 regression? :/</p>



<a name="237348569"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237348569" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237348569">(May 04 2021 at 15:42)</a>:</h4>
<p>hm</p>



<a name="237348577"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237348577" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237348577">(May 04 2021 at 15:42)</a>:</h4>
<p>found it while going through the regression-from-stable-to-nightly to promote them to beta :/</p>



<a name="237348580"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237348580" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237348580">(May 04 2021 at 15:42)</a>:</h4>
<p>not sure</p>



<a name="237348596"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237348596" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237348596">(May 04 2021 at 15:42)</a>:</h4>
<p>it's just i-slow though</p>



<a name="237348632"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237348632" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237348632">(May 04 2021 at 15:42)</a>:</h4>
<p>we had an llvm upgrade so a bunch of runtime improvements and regressions are expected</p>



<a name="237348704"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237348704" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237348704">(May 04 2021 at 15:43)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/pull/82806">https://github.com/rust-lang/rust/pull/82806</a> is after the llvm upgrade, but dunno</p>



<a name="237348882"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237348882" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237348882">(May 04 2021 at 15:44)</a>:</h4>
<p>not sure, sorry</p>



<a name="237349371"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237349371" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237349371">(May 04 2021 at 15:47)</a>:</h4>
<p>doesn't seem worth rebuilding the release just for it, it's I-prioritize now anyway so it'll get picked up</p>



<a name="237349798"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237349798" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237349798">(May 04 2021 at 15:49)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/issues/83060">https://github.com/rust-lang/rust/issues/83060</a> also was not relabeled :/</p>



<a name="237349816"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237349816" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237349816">(May 04 2021 at 15:49)</a>:</h4>
<p>thankfully that was <code>probe-stack=inline-asm</code> so we fixed it by accident</p>



<a name="237350147"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237350147" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237350147">(May 04 2021 at 15:51)</a>:</h4>
<p>yeah I'm not surprised</p>



<a name="237350172"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237350172" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237350172">(May 04 2021 at 15:51)</a>:</h4>
<p>relabeling is painful and a lot of work</p>



<a name="237350187"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237350187" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237350187">(May 04 2021 at 15:51)</a>:</h4>
<p>milestones!</p>



<a name="237361112"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237361112" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237361112">(May 04 2021 at 16:57)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/pull/84909#issuecomment-832028701">https://github.com/rust-lang/rust/pull/84909#issuecomment-832028701</a></p>



<a name="237361134"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237361134" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237361134">(May 04 2021 at 16:57)</a>:</h4>
<p>[6:55 PM] jynelson: also there will be no quick fix for this, it will need changes to the testsuite<br>
[6:56 PM] jynelson: either by running sed s/nightly/beta or by changing htmldocck to substitute the channel itself<br>
[6:57 PM] jynelson: ok. I don't have time to run a local build right now, but if you run x.py test --stage 1 src/test/rustdoc/intra-doc with channel = beta it should replicate the issue</p>



<a name="237361142"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237361142" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237361142">(May 04 2021 at 16:57)</a>:</h4>
<p>on discord, <span class="user-mention" data-user-id="232545">@Joshua Nelson</span></p>



<a name="237361390"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237361390" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237361390">(May 04 2021 at 16:59)</a>:</h4>
<p>you missed the most important comment:</p>
<blockquote>
<p>... did someone finally fix the issue where beta links to nightly?</p>
</blockquote>



<a name="237361409"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237361409" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237361409">(May 04 2021 at 16:59)</a>:</h4>
<p>would be really exciting if so</p>



<a name="237361444"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237361444" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237361444">(May 04 2021 at 16:59)</a>:</h4>
<p>I really wish there were a way to automatically test different channels</p>



<a name="237379463"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237379463" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237379463">(May 04 2021 at 18:52)</a>:</h4>
<p>unfortunately I can't continue looking at this today, I'll have more time tomorrow</p>



<a name="237420688"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237420688" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237420688">(May 05 2021 at 00:12)</a>:</h4>
<p>bisecting this now</p>



<a name="237428268"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237428268" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237428268">(May 05 2021 at 01:38)</a>:</h4>
<p>bisecting commits is harder than expected because some commits don't build - I've confirmed up until <a href="https://github.com/rust-lang/rust/commit/3f2ca47a79911d422fd47ee2a23dd08a9fa42aa9">3f2ca47a79911d422fd47ee2a23dd08a9fa42aa9</a> passes the test suite</p>



<a name="237428306"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237428306" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237428306">(May 05 2021 at 01:39)</a>:</h4>
<p>unfortunately bisect-rustc doesn't work because I can't override the channel after the binary has been built :/</p>



<a name="237433411"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237433411" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237433411">(May 05 2021 at 02:55)</a>:</h4>
<p>ok well I gave up on bisecting automatically and it took about 5 seconds to find by hand - <span class="user-mention" data-user-id="121055">@Pietro Albini</span> this will work around it temporarily:</p>
<div class="codehilite" data-code-language="Diff"><pre><span></span><code><span class="gh">diff --git a/src/librustdoc/clean/types.rs b/src/librustdoc/clean/types.rs</span>
<span class="gh">index 5e47144588b..a1d689d8921 100644</span>
<span class="gd">--- a/src/librustdoc/clean/types.rs</span>
<span class="gi">+++ b/src/librustdoc/clean/types.rs</span>
<span class="gu">@@ -394,8 +394,7 @@ pub fn from_def_id_and_attrs_and_parts(</span>
                                     format!("{}/std/", s.trim_end_matches('/'))
                                 }
                                 Some(&amp;(_, _, ExternalLocation::Unknown)) | None =&gt; format!(
<span class="gd">-                                    "https://doc.rust-lang.org/{}/std/",</span>
<span class="gd">-                                    crate::doc_rust_lang_org_channel(),</span>
<span class="gi">+                                    "https://doc.rust-lang.org/nightly/std/",</span>
                                 ),
                             };
                             // This is a primitive so the url is done "by hand".
</code></pre></div>



<a name="237433423"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237433423" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237433423">(May 05 2021 at 02:55)</a>:</h4>
<p>but I would like to fix the test suite eventually</p>



<a name="237434797"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237434797" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237434797">(May 05 2021 at 03:16)</a>:</h4>
<p><span class="user-mention silent" data-user-id="232545">Joshua Nelson</span> <a href="#narrow/stream/241545-t-release/topic/1.2E52.20release/near/237433423">said</a>:</p>
<blockquote>
<p>but I would like to fix the test suite eventually</p>
</blockquote>
<p>ugh apparently rustdoc is very buggy and sometimes generates nightly and sometimes beta</p>



<a name="237434804"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237434804" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237434804">(May 05 2021 at 03:17)</a>:</h4>
<p>so the revert I posted above is probably best for now</p>



<a name="237435769"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237435769" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237435769">(May 05 2021 at 03:33)</a>:</h4>
<p>oh I see, it's because libstd has an html_root_url of /nightly/</p>



<a name="237435772"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237435772" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237435772">(May 05 2021 at 03:33)</a>:</h4>
<p>ugh yes this is complicated</p>



<a name="237435853"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237435853" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237435853">(May 05 2021 at 03:34)</a>:</h4>
<p>cc <a href="#narrow/stream/122651-general/topic/Rustdoc.20unconditionally.20links.20to.20nightly.20libstd.20docs">https://rust-lang.zulipchat.com/#narrow/stream/122651-general/topic/Rustdoc.20unconditionally.20links.20to.20nightly.20libstd.20docs</a></p>



<a name="237470287"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237470287" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237470287">(May 05 2021 at 10:06)</a>:</h4>
<p>ended up reverting the whole commit that changed links to {channel}, as it <em>also</em> regressed Rustdoc UI tests</p>



<a name="237470292"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237470292" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237470292">(May 05 2021 at 10:06)</a>:</h4>
<p>let's hope now it works</p>



<a name="237470316"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237470316" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237470316">(May 05 2021 at 10:06)</a>:</h4>
<p>we <em>definitely</em> need a retro for this cycle, we can't do things like this every 6 weeks</p>



<a name="237482385"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237482385" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237482385">(May 05 2021 at 11:57)</a>:</h4>
<p><span class="user-mention" data-user-id="121055">@Pietro Albini</span> lmk if you need any urgent review on the PR(s)</p>



<a name="237482431"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237482431" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237482431">(May 05 2021 at 11:57)</a>:</h4>
<p>ok! I'll wait to see what CI yells at me this time and ping you accordingly</p>



<a name="237488007"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237488007" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237488007">(May 05 2021 at 12:42)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> <a href="https://github.com/rust-lang/rust/pull/84909">https://github.com/rust-lang/rust/pull/84909</a> and <a href="https://github.com/rust-lang/rust/pull/84950">https://github.com/rust-lang/rust/pull/84950</a></p>



<a name="237488427"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237488427" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237488427">(May 05 2021 at 12:45)</a>:</h4>
<p><span class="user-mention" data-user-id="121055">@Pietro Albini</span> did you see Joshua's comments in the second one?</p>



<a name="237488455"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237488455" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237488455">(May 05 2021 at 12:45)</a>:</h4>
<p>I'm personally inclined to fully revert but not clear</p>



<a name="237488485"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237488485" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237488485">(May 05 2021 at 12:45)</a>:</h4>
<p>oh saw it right now</p>



<a name="237488528"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237488528" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237488528">(May 05 2021 at 12:45)</a>:</h4>
<p>honestly at least for beta I'd prefer to fully revert too</p>



<a name="237488598"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237488598" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237488598">(May 05 2021 at 12:46)</a>:</h4>
<p>the failure is only because it's /beta/ instead of /nightly/, right?</p>



<a name="237488636"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237488636" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237488636">(May 05 2021 at 12:46)</a>:</h4>
<p>that's a very simple text change, and the original PR was not risky either</p>



<a name="237488989"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237488989" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237488989">(May 05 2021 at 12:48)</a>:</h4>
<p>The PR has other problems looking at it</p>



<a name="237489000"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237489000" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237489000">(May 05 2021 at 12:48)</a>:</h4>
<p>I think we should revert on beta</p>



<a name="237489012"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237489012" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237489012">(May 05 2021 at 12:49)</a>:</h4>
<p>reverting the entire second commit is correct</p>



<a name="237489027"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237489027" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237489027">(May 05 2021 at 12:49)</a>:</h4>
<p>but there's only one change that needs to be made to the first commit</p>



<a name="237489048"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237489048" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237489048">(May 05 2021 at 12:49)</a>:</h4>
<p>Is there a reason to not revert the whole thing? That seems like the best option to me</p>



<a name="237489068"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237489068" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237489068">(May 05 2021 at 12:49)</a>:</h4>
<p>it just seems like a shame when there's nothing wrong with it :/</p>



<a name="237489095"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237489095" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237489095">(May 05 2021 at 12:49)</a>:</h4>
<p>like, there's 0% chance of the fix being wrong if CI passes</p>



<a name="237489161"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237489161" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237489161">(May 05 2021 at 12:50)</a>:</h4>
<p>I prefer to keep things simple personally in terms of what is or isn't on various branches</p>



<a name="237489195"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237489195" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237489195">(May 05 2021 at 12:50)</a>:</h4>
<p>So I'm inclined to fully drop from beta</p>



<a name="237489218"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237489218" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237489218">(May 05 2021 at 12:50)</a>:</h4>
<p>(and master with the option of course for someone to readd)</p>



<a name="237489311"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237489311" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237489311">(May 05 2021 at 12:51)</a>:</h4>
<p>ok - I can make the proper fix as a PR to master then</p>



<a name="237489428"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237489428" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237489428">(May 05 2021 at 12:52)</a>:</h4>
<p><span class="user-mention" data-user-id="121055">@Pietro Albini</span> did the beta PR description omit this rustdoc bit?</p>



<a name="237489442"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237489442" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237489442">(May 05 2021 at 12:52)</a>:</h4>
<p>"Revert PR 83866"</p>



<a name="237489460"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237489460" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237489460">(May 05 2021 at 12:52)</a>:</h4>
<p>third bullet point</p>



<a name="237489477"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237489477" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237489477">(May 05 2021 at 12:52)</a>:</h4>
<p>F5 if you haven't in a while</p>



<a name="237489478"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237489478" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237489478">(May 05 2021 at 12:52)</a>:</h4>
<p>Ah ok</p>



<a name="237489505"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237489505" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237489505">(May 05 2021 at 12:53)</a>:</h4>
<p>Can you remove the "this is not ready" language? If reasonable?</p>



<a name="237489556"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237489556" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237489556">(May 05 2021 at 12:53)</a>:</h4>
<p>done</p>



<a name="237489573"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237489573" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237489573">(May 05 2021 at 12:53)</a>:</h4>
<p><span class="user-mention silent" data-user-id="232545">Joshua Nelson</span> <a href="#narrow/stream/241545-t-release/topic/1.2E52.20release/near/237489311">said</a>:</p>
<blockquote>
<p>ok - I can make the proper fix as a PR to master then</p>
</blockquote>
<p>(this would also be fixed by <a href="https://github.com/rust-lang/rust/pull/84942">https://github.com/rust-lang/rust/pull/84942</a> but that PR may not land for quite a while)</p>



<a name="237489939"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237489939" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237489939">(May 05 2021 at 12:56)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> do we want to p=100 the beta PR?</p>



<a name="237489971"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237489971" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237489971">(May 05 2021 at 12:56)</a>:</h4>
<p><span class="user-mention" data-user-id="121055">@Pietro Albini</span> hm yeah I think so, I want to get crater kicked off soon</p>



<a name="237489998"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237489998" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237489998">(May 05 2021 at 12:56)</a>:</h4>
<p>who's doing it? :D</p>



<a name="237490021"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237490021" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237490021">(May 05 2021 at 12:57)</a>:</h4>
<p>You</p>



<a name="237490031"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237490031" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237490031">(May 05 2021 at 12:57)</a>:</h4>
<p>ok</p>



<a name="237490065"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237490065" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237490065">(May 05 2021 at 12:57)</a>:</h4>
<p>done</p>



<a name="237503315"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237503315" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237503315">(May 05 2021 at 14:24)</a>:</h4>
<p>oh ugh I forgot the rustfmt revert</p>



<a name="237503323"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237503323" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237503323">(May 05 2021 at 14:24)</a>:</h4>
<p>will fix it in a bit</p>



<a name="237537597"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237537597" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237537597">(May 05 2021 at 17:49)</a>:</h4>
<p>hmm rls is failing on aarch64</p>



<a name="237537607"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237537607" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237537607">(May 05 2021 at 17:49)</a>:</h4>
<p><span class="user-mention" data-user-id="121055">@Pietro Albini</span> I think this is another "always need to add" patch</p>



<a name="237537622"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237537622" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237537622">(May 05 2021 at 17:49)</a>:</h4>
<p>really should just disable the nightly build</p>



<a name="237537735"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237537735" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237537735">(May 05 2021 at 17:50)</a>:</h4>
<p>ugh let me add it</p>



<a name="237538330"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237538330" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237538330">(May 05 2021 at 17:54)</a>:</h4>
<p>ok cherry-picked</p>



<a name="237669052"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237669052" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237669052">(May 06 2021 at 14:40)</a>:</h4>
<p>will start the release in 20 minutes</p>



<a name="237672754"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237672754" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237672754">(May 06 2021 at 15:01)</a>:</h4>
<p>Build started with ID 'promote-release--prod:62c6e9b2-49dc-4a41-874b-821fcc2a66f2'</p>



<a name="237680518"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237680518" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237680518">(May 06 2021 at 15:40)</a>:</h4>
<p>uploading files</p>



<a name="237681203"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237681203" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237681203">(May 06 2021 at 15:44)</a>:</h4>
<p>pushing the tag</p>



<a name="237681376"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237681376" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237681376">(May 06 2021 at 15:45)</a>:</h4>
<p>started a thanks rebuild</p>



<a name="237682539"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237682539" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237682539">(May 06 2021 at 15:52)</a>:</h4>
<p>tagged cargo</p>



<a name="237682998"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237682998" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237682998">(May 06 2021 at 15:55)</a>:</h4>
<p>merged blog post</p>



<a name="237683096"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237683096" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237683096">(May 06 2021 at 15:55)</a>:</h4>
<p><a href="/user_uploads/4715/h1GS9SJjrJoCf2plvYKtR_h-/2021-05-06-17-55-19.png">2021-05-06-17-55-19.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/h1GS9SJjrJoCf2plvYKtR_h-/2021-05-06-17-55-19.png" title="2021-05-06-17-55-19.png"><img src="/user_uploads/4715/h1GS9SJjrJoCf2plvYKtR_h-/2021-05-06-17-55-19.png"></a></div>



<a name="237683245"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237683245" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237683245">(May 06 2021 at 15:56)</a>:</h4>
<p>Just, under an hour to release. Is that a record? Feels like it takes longer usually <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span></p>



<a name="237683313"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237683313" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237683313">(May 06 2021 at 15:56)</a>:</h4>
<p>it always takes around 55 minutes nowadays</p>



<a name="237683602"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237683602" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237683602">(May 06 2021 at 15:58)</a>:</h4>
<p><a href="https://blog.rust-lang.org/2021/05/06/Rust-1.52.0.html">https://blog.rust-lang.org/2021/05/06/Rust-1.52.0.html</a> <span aria-label="tada" class="emoji emoji-1f389" role="img" title="tada">:tada:</span> <span aria-label="tada" class="emoji emoji-1f389" role="img" title="tada">:tada:</span> <span aria-label="tada" class="emoji emoji-1f389" role="img" title="tada">:tada:</span></p>



<a name="237683781"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237683781" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237683781">(May 06 2021 at 15:59)</a>:</h4>
<p>Yay, no caching issues this time <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span></p>



<a name="237687555"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237687555" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237687555">(May 06 2021 at 16:21)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> blog post fixes to merge: <a href="https://github.com/rust-lang/blog.rust-lang.org/pull/834">https://github.com/rust-lang/blog.rust-lang.org/pull/834</a></p>



<a name="237687715"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237687715" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237687715">(May 06 2021 at 16:21)</a>:</h4>
<p>Done</p>



<a name="237687911"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237687911" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237687911">(May 06 2021 at 16:23)</a>:</h4>
<p>thanks <span aria-label="heart" class="emoji emoji-2764" role="img" title="heart">:heart:</span></p>



<a name="237699525"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237699525" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237699525">(May 06 2021 at 17:42)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> one last thing before the release is done -- I noticed <a href="https://github.com/rust-lang/stdarch/blob/50e72a215d2bd2c40593786c6a3e10d5ab8bdb39/crates/core_arch/src/mod.rs#L3">https://github.com/rust-lang/stdarch/blob/50e72a215d2bd2c40593786c6a3e10d5ab8bdb39/crates/core_arch/src/mod.rs#L3</a> had a <code>not(bootstrap)</code> for a while (at least three releases), is there any reason why it wasn't removed? or if there wasn't any, should I just open a PR?</p>



<a name="237699626"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237699626" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237699626">(May 06 2021 at 17:42)</a>:</h4>
<p>Uh submodule bumps are not something I myself do</p>



<a name="237699689"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237699689" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237699689">(May 06 2021 at 17:43)</a>:</h4>
<p>I think stdarch bump in particular had been blocked on some other stuff for a while</p>



<a name="237699715"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237699715" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237699715">(May 06 2021 at 17:43)</a>:</h4>
<p>But I don't really know anything about it</p>



<a name="237715255"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237715255" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237715255">(May 06 2021 at 19:25)</a>:</h4>
<p>tried opening a PR for it</p>



<a name="237715270"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/237715270" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#237715270">(May 06 2021 at 19:25)</a>:</h4>
<p><a href="https://github.com/rust-lang/stdarch/pull/1150">https://github.com/rust-lang/stdarch/pull/1150</a></p>



<a name="238114823"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/238114823" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#238114823">(May 10 2021 at 09:59)</a>:</h4>
<p>does anyone have a clue around <a href="https://github.com/rust-lang/rust/pull/84985#issuecomment-836496081">https://github.com/rust-lang/rust/pull/84985#issuecomment-836496081</a> ?</p>



<a name="238123548"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/238123548" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#238123548">(May 10 2021 at 11:20)</a>:</h4>
<p>Yeah</p>



<a name="238123616"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/238123616" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#238123616">(May 10 2021 at 11:20)</a>:</h4>
<p><span class="user-mention" data-user-id="121055">@Pietro Albini</span> there was some last minute fixes to no coverage feature gating that probably didn't hit beta</p>



<a name="238123656"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/238123656" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#238123656">(May 10 2021 at 11:21)</a>:</h4>
<p>(it was gated in a different and actually not working way iirc)</p>



<a name="238123669"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/238123669" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#238123669">(May 10 2021 at 11:21)</a>:</h4>
<p>uh, yeah, but that's on master</p>



<a name="238123678"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/238123678" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#238123678">(May 10 2021 at 11:21)</a>:</h4>
<p>(bootstrap update to beta 1.53)</p>



<a name="238123778"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/238123778" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#238123778">(May 10 2021 at 11:22)</a>:</h4>
<p>oh wait do I need to have <code>#[cfg_attr(not(bootstrap), feature(no_coverage))]</code> in <a href="http://lib.rs">lib.rs</a> and <code>#[cfg_attr(bootstrap, feature(no_coverage))]</code> on the function?</p>



<a name="238123780"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/238123780" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#238123780">(May 10 2021 at 11:22)</a>:</h4>
<p>Right I'm saying it probably needs "old" style gating? If you want to ping me on the PR I can take a closer look later</p>



<a name="238123791"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/238123791" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#238123791">(May 10 2021 at 11:22)</a>:</h4>
<p>Yeah that's what I'm thinking</p>



<a name="238123816"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/238123816" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#238123816">(May 10 2021 at 11:22)</a>:</h4>
<p>ok I'll try in a bit</p>



<a name="238123825"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/238123825" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#238123825">(May 10 2021 at 11:22)</a>:</h4>
<p>We probably need to backport the feature gate fixes anyway fwiw</p>



<a name="238123830"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/238123830" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#238123830">(May 10 2021 at 11:22)</a>:</h4>
<p>(or a revert)</p>



<a name="238220831"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/238220831" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> tmandry <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#238220831">(May 10 2021 at 22:21)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/issues/84871">#84871</a> is the fix (already beta nominated)</p>



<a name="238633836"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/238633836" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#238633836">(May 13 2021 at 15:05)</a>:</h4>
<p>Just a heads up for you all in <span class="user-group-mention" data-user-group-id="2907">@T-release</span> : we’re going to have a zulip meeting tomorrow in <a class="stream-topic" data-stream-id="238009" href="/#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bsteering.20meeting.5D.202021-05-14.20fingerprints.2C.201.2E52.2E2.3F.20.2384970">#t-compiler/meetings &gt; [steering meeting] 2021-05-14 fingerprints, 1.52.2? #84970</a> at  <time datetime="2021-05-14T14:00:00Z">2021-05-14T10:00:00-04:00</time></p>



<a name="238633976"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/1.52%20release/near/238633976" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/1.2E52.20release.html#238633976">(May 13 2021 at 15:06)</a>:</h4>
<p>(the reason I mention it here is that I want to float the idea of a 1.52.2 release. There is definitely debate to be had here, but I want to make sure we consider it, given how many people expressed unhappiness at incr-comp being turned off by default.)</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>